aaron.ballman added a comment.

In D152090#4395192 <https://reviews.llvm.org/D152090#4395192>, @hans wrote:

> Should there be a test?

+1

Also, a release note so users know about the public-facing option?



================
Comment at: clang/include/clang/Driver/Options.td:1611
 def ferror_limit_EQ : Joined<["-"], "ferror-limit=">, Group<f_Group>, 
Flags<[CoreOption]>;
+def fcaret_diagnostics_max_lines_EQ : Joined<["-"], 
"fcaret-diagnostics-max-lines=">, Group<f_Group>, Flags<[CoreOption]>;
 defm exceptions : BoolFOption<"exceptions",
----------------
This should have `HelpText` as well, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152090/new/

https://reviews.llvm.org/D152090

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to