MaskRay added a comment. In D152090#4398097 <https://reviews.llvm.org/D152090#4398097>, @tbaeder wrote:
> In D152090#4395827 <https://reviews.llvm.org/D152090#4395827>, @MaskRay wrote: > >> `def fcaret_diagnostics_max_lines` in `Options.td` has the `NoDriverOption` >> flag. Move it to other places with `BooleainFFlag` should work. >> Then in `Clang.cpp` you can just write `Args.AddLastArg(...)` >> >> Can you add some description that this is related to D147875 >> <https://reviews.llvm.org/D147875> ? > > Can you give a more concrete example? I modeled this patch after existing > similar options, like `-fmacro-backtrace-limit`. Thanks for mentioning `-fmacro-backtrace-limit`. I changed it and a few similar options to the perfered form in 0aa4af711e567c8683cee95ffbb14812df03cecc <https://reviews.llvm.org/rG0aa4af711e567c8683cee95ffbb14812df03cecc> We have many legacy `Separate` form CC1 options that unnecessarily differ from their `Joined` (ended with `=`) driver option counterparts. New code is recommended to use `Flags<[CC1Option]>,`. As a general advice, if you see `Separate`, chances are that they likely don't use the best practice... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
