nickdesaulniers added inline comments.
================
Comment at: clang/test/Frontend/stack-layout-remark.c:8
+// RUN: mkdir -p %t
+// RUN: %clang_cc1 %s -emit-codegen-only -triple x86_64-unknown-linux-gnu
-target-cpu corei7 -Rpass-analysis=stack-frame-layout -o /dev/null -O0 2>&1 |
FileCheck %s --check-prefix=O0-NODEBUG
+// RUN: %clang_cc1 %s -emit-codegen-only -triple x86_64-unknown-linux-gnu
-target-cpu corei7 -Rpass-analysis=stack-frame-layout -o /dev/null -O0
-debug-info-kind=constructor -dwarf-version=5 -debugger-tuning=gdb 2>&1 |
FileCheck %s --check-prefix=O0-DEBUG
----------------
nickdesaulniers wrote:
> Please update:
> 1. the patch description/commit message
> 2. clang/docs/ReleaseNotes.rst
>
> to mention this new flag. I kind of wish that `-Wstack-frame-larger-than=`
> alluded to this somehow.
Perhaps in the documentation for `-Wframe-larger-than=`? i.e. adding a `code
Documentation = [{}]` block to `BackendFrameLargerThan` record in
clang/include/clang/Basic/DiagnosticGroups.td or something.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135488/new/
https://reviews.llvm.org/D135488
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
