paulkirth added a comment.

I think ideally I'd like to surface something like this:

A:
F26139353: image.png <https://reviews.llvm.org/F26139353>

or

B:
F26139363: image.png <https://reviews.llvm.org/F26139363>

The first image uses stdout, and the second uses remarks, but prints everything 
from the function as a single string. This provides some output that is pretty 
easy for a human to consume, and wouldn't be too hard to parse for an external 
tool. It isn't as nice from a machine readable perspective as something like 
JSON or YAML.

The big issue that I'm seeing is that printing multiple remarks ends up 
printing the path to the source file given as provided on the commandline. If 
that's from a build system, it will likely be a full path and a user is likely 
going to have a similar issue. The following examples are, IMO, much harder to 
make sense of. I see similar issues, even if I make my terminal full screen 
width.

C: 
F26139426: image.png <https://reviews.llvm.org/F26139426>

or (if I format things as suggested)

D: 
F26139432: image.png <https://reviews.llvm.org/F26139432>

I'm a bit stumped on how to make this work nicely w/ remarks and provide good 
support for both the CLI and YAML...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to