erichkeane added a comment. In D126907#3737375 <https://reviews.llvm.org/D126907#3737375>, @Mordante wrote:
> This change breaks libc++'s modular build see build > https://buildkite.com/llvm-project/libcxx-ci/builds/12991 > Reverting this commit on top of yesterday's build (before your revert) fixes > the issue. > > libc++'s modular build uses Clang's pre-C++20 modules. > > It can be reproduced building libc++ and running the following lit invocation > `${LIT} -Denable_modules=True > libcxx/test/libcxx/ranges/range.adaptors/range.all/all.nodiscard.verify.cpp` > > If you need assistance testing a new version of this patch on libc++ please > let me know. Is this not part of check-runtimes or check-cxx? I ran both of those INCLUDING a modules-builds-all... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
