MaskRay added a comment.

In D118948#3427401 <https://reviews.llvm.org/D118948#3427401>, @hctim wrote:

> In D118948#3427344 <https://reviews.llvm.org/D118948#3427344>, @tschuett 
> wrote:
>
>> Is `-fsanitize=memtag-heap` Android specific or target independent? It 
>> passes Android flags to the linker?!?
>
> The frontend flag should be target-independent. The clang driver knows to 
> only pass Android flags to the linker where `TC.getTriple().isAndroid()` is 
> true. This should allow a glibc-based implementation to live under the same 
> `-fsanitize=memtag-heap` flag, just chainging the implementation based on the 
> target.

Since this driver option has no-op for glibc/musl, by convention it should 
report an `err_drv_unsupported_opt_for_target` error.
This allows configure-time detection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118948/new/

https://reviews.llvm.org/D118948

STAMPS
actor(@MaskRay) application(Differential) author(@hctim) herald(H45) 
herald(H69) herald(H74) herald(H105) herald(H123) herald(H208) herald(H311) 
herald(H343) herald(H423) herald(H477) herald(H501) herald(H576) herald(H597) 
herald(H615) herald(H649) herald(H678) herald(H688) herald(H697) herald(H704) 
herald(H723) herald(H864) mention(@hctim) mention(@tschuett) monogram(D118948) 
object-type(DREV) phid(PHID-DREV-pdirnu4zuvlfhlklabzj) reviewer(@eugenis) 
reviewer(@MaskRay) revision-repository(rG) revision-status(needs-review) 
subscriber(@arichardson) subscriber(@cfe-commits) subscriber(@dang) 
subscriber(@dexonsmith) subscriber(@emaste) subscriber(@llvm-commits) 
subscriber(@pcc) subscriber(@StephenFan) subscriber(@tschuett) tag(#all) 
tag(#clang) tag(#llvm) via(web)

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to