RedDocMD added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:143 + llvm::ArrayRef<llvm::StringLiteral> ValidNames(STD_PTR_NAMES); + return llvm::is_contained(ValidNames, Name); } ---------------- vsavchenko wrote: > And why can't we pass `STD_PTR_NAMES` directly to `llvm::is_contained`? Ooh, so there is an overload for that as well. :) ================ Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:381 + const MemRegion *ThisRegion = DC->getCXXThisVal().getAsRegion(); + assert(ThisRegion && "We do not support explicit calls to destructor"); + const auto *InnerPtrVal = State->get<TrackedRegionMap>(ThisRegion); ---------------- vsavchenko wrote: > And if it happens we are going to crash with assertion failure? Assuming assertions are enabled, that is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
