NoQ added a comment.

In D105821#2904870 <https://reviews.llvm.org/D105821#2904870>, @NoQ wrote:

> `std::make_unique` isn't actually getting modeled but inlined instead (I have 
> all your patches pulled and this patch applied; and the 
> object-under-construction seems to be available later, in both C++11 and 
> C++17, so it's kinda weird and needs more debugging)

Uh-oh, sorry, wrong clang! `std::make_unique` is indeed modeled. I think the 
only problem with your invocation is the missing checker. And it also indeed 
confirms my suggestion that the constructor inside `make_unique` should be 
modeled, at least conservatively like we did with destructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105821/new/

https://reviews.llvm.org/D105821

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to