alexfh added inline comments.
================
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+AST_MATCHER(Stmt, unresolvedLookupExpr) {
+ return isa<UnresolvedLookupExpr>(Node);
----------------
hokein wrote:
> alexfh wrote:
> > That's because we need a node matcher, not narrowing matcher. I guess, this
> > should work:
> >
> > const internal::VariadicAllOfMatcher<UnresolvedLookupExpr>
> > unresolvedLookupExpr;
> Yeah. But as the name indicates, `VariadicAllOfMatcher` is used internally in
> ASTMatcher, is it reasonable to use it here? I can't find such usage in
> clang-tidy side.
There are far fewer nodes in the AST than their properties, so the core
matchers library should contain all node matchers. Thus, the user code is not
supposed to create any node matchers and the corresponding API is considered an
implementation detail of the matchers library. It's fine to use internal API
here for a short period until we move the matcher to the core matchers library.
http://reviews.llvm.org/D20326
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
