JonChesterfield added a comment.
I believe this is 'safe', in the sense that it can't break anything other than
AMDGPU's openmp implementation, which doesn't work yet anyway. The change to
non-amd code is to OpenMPActionBuilder, and while parsing `-march=gfx` isn't
pretty, it won't fire on nvptx. I'm not particularly confident it is correct,
but it's hard to do comprehensive testing before there's an end to end spike.
I'd like to iterate in tree, with an expectation that parts of this will need
to change - @jdoerfert does the OpenMP patch look adequate for now?
================
Comment at: clang/lib/Driver/Driver.cpp:755
TC = CudaTC.get();
+ } else if (TT.isAMDGCN()) {
+ const ToolChain *HostTC =
----------------
This follows the same logic as nvptx so is likely to be correct
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94961/new/
https://reviews.llvm.org/D94961
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
