JonChesterfield added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:65
+ .Case("g", "1")
+ .Default("2");
+ }
----------------
JonChesterfield wrote:
> jdoerfert wrote:
> > To verify, O0 is not mapped to O2, correct?
> I think `opt -O0` is an error, though it does look like this will rewrite it
> to O2 instead. Which seems bad.
Suggest we drop the opt invocation. llvm-link is required for the case where
multiple files are passed to clang as a single invocation, but I don't see why
we need an opt invocation here. Passing the llvm-link'ed code to llc as-is,
without this implicit lto style opt invocation, is probably a better default.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94961/new/
https://reviews.llvm.org/D94961
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
