JonChesterfield added inline comments.
================
Comment at: openmp/libomptarget/deviceRTLs/common/src/libcall.cu:319
-EXTERN int omp_is_initial_device(void) {
- PRINT0(LD_IO, "call omp_is_initial_device() returns 0\n");
- return 0; // 0 by def on device
-}
+// EXTERN int omp_is_initial_device(void) {
+// PRINT0(LD_IO, "call omp_is_initial_device() returns 0\n");
----------------
tianshilei1992 wrote:
> I think we could safely delete this function because function call in device
> code can always be taken as builtin so this function will never be called.
> WDYT? @jdoerfert @JonChesterfield
Yes. There is an existing bug that &omp_is_initial_device doesn't work, but
because of that nothing can call this function. We can reinstate it when
replacing the builtin.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94745/new/
https://reviews.llvm.org/D94745
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
