gtbercea added a comment.
In D63009#1544758 <https://reviews.llvm.org/D63009#1544758>, @Hahnfeld wrote:
> Am I correct that the second to last revision ("- Fix tests.") removed all
> checks for the actual `device_id` argument from the tests? From my point of
> view that's not fixing but weakening the tests! Can you explain why they
> needed "fixing"?
When I was just passing the default value the LLVM-IR was: i64 -1 i.e.
constant, easy to check.
With the latest change the emitted code is: i64 %123 i.e. where %123 is a local
derived from the expression of the device ID.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63009/new/
https://reviews.llvm.org/D63009
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
