Hahnfeld added a comment.
Am I correct that the second to last revision ("- Fix tests.") removed all
checks for the actual `device_id` argument from the tests? From my point of
view that's not fixing but weakening the tests! Can you explain why they needed
"fixing"?
If I had to guess this is because some directives have the `device` clause, so
the tests should check that the generated code passes the correct argument in
that case.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63009/new/
https://reviews.llvm.org/D63009
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
