xazax.hun added a comment. In http://reviews.llvm.org/D12906#248418, @honggyu.kim wrote:
> (3) bug type (bug message) As far as I remember the other version of this patch exclude any message that is displayed to the user deliberately, to make the hash more resilient to changes to those strings. As always, there is a trade off here, and in order to decide we need to have the exact scope of the hash. If we expect to only compare hashes that was generated with the same version of clang, it is great to include that in the hash. If we want to compare hashes that was generated by different versions of clang, this might not be a good idea, depending on how often are those messages changes. The original patch included the check_name in the hash. Unfortunately that might change too. http://reviews.llvm.org/D12906 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
