honggyu.kim added a comment.

Just to make it simpler to understand, original strings of issue_hash are as 
below with this patch:

BUG 1

  3$returna;$Garbage return value

BUG 2

  3$intb=a;$Assigned value is garbage or undefined

BUG 3

  3$returna;$Garbage return value

This consists of the 3 fields:

  (1)$(2)$(3)

(1) column number
(2) source line string after removing whitespace
(3) bug type (bug message)

And GetHashOfContent generates 32 letters of hash values based on those strings.
By comparing hash values of those strings, this patch allows CmpRuns.py 
distinguish such cases.

  $ CmpRuns.py bug1/ bug2/
  REMOVED: 'bug.c:4:3, Logic error: Undefined or garbage value returned to 
caller'
  ADDED: 'bug.c:4:3, Logic error: Assigned value is garbage or undefined'
  TOTAL REPORTS: 1
  TOTAL DIFFERENCES: 2
  
  $ CmpRuns.py bug1/ bug3/
  TOTAL REPORTS: 1
  TOTAL DIFFERENCES: 0

Since CmpRuns.py also compares "file name" and "function name" with 
"issue_hash" in plist file, we uses 5 different information to compare bug 
reports.


http://reviews.llvm.org/D12906



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to