----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120940/#review76787 -----------------------------------------------------------
Cool, almost done. Last remarksL 1. For a CSV wiht these 3 lines: 1,#"2" #7,1 3#,"4" The result ius http://i.imgur.com/T8Uj6ks.png The second row should not be imported as the most likely intention is to skip entire row that's used just for a comment. For multiline comments e.g. explaining data, the result would be even more unexpected: multiple empty records. 2. Column names. For a CSV with these 2 lines: A, B, C, D 1,2 and without the hashtag option a table with 4 column and 1 row is imported with value: 1, 2, NULL, NULL This is OK. For a CSV with these 2 lines: A, B#, C, D 1,#2 and with the hashtag option set ON a table with 1 column and 1 row is imported with value: 1 I think there should be 2 columns/values: 1, NULL kexi/plugins/importexport/csv/kexicsvwidgets.cpp <https://git.reviewboard.kde.org/r/120940/#comment52857> ->availableCommentSymbols - Jarosław Staniek On March 1, 2015, 12:35 a.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120940/ > ----------------------------------------------------------- > > (Updated March 1, 2015, 12:35 a.m.) > > > Review request for Calligra, Adam Pigg and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > When hash sign (#) appears in csv file at the beginning of the line or in the > middle of unqouted field > it is treated as the beginning of the comment and the following data is being > ignored until the end of the row > > > Diffs > ----- > > kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4 > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285 > kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd > kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4 > libs/widgets/KoCsvImportDialog.cpp 8d042d7 > > Diff: https://git.reviewboard.kde.org/r/120940/diff/ > > > Testing > ------- > > Able to activate/deactivate parsing comments. When activated able to choose > specific sign > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
