----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120940/#review76749 -----------------------------------------------------------
Ship it! Looks good! Please fix minor things. kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <https://git.reviewboard.kde.org/r/120940/#comment52835> -> "Comment symbol:" kexi/plugins/importexport/csv/kexicsvwidgets.cpp <https://git.reviewboard.kde.org/r/120940/#comment52833> + empty row kexi/plugins/importexport/csv/kexicsvwidgets.cpp <https://git.reviewboard.kde.org/r/120940/#comment52834> Remove the checkbox, instead prepend the i18nc("No comment sign", "None") item to the combo (as the 1st item). - Jarosław Staniek On Feb. 26, 2015, 11:02 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120940/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 11:02 p.m.) > > > Review request for Calligra, Adam Pigg and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > When hash sign (#) appears in csv file at the beginning of the line or in the > middle of unqouted field > it is treated as the beginning of the comment and the following data is being > ignored until the end of the row > > > Diffs > ----- > > kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4 > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285 > kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd > kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4 > libs/widgets/KoCsvImportDialog.cpp 8d042d7 > > Diff: https://git.reviewboard.kde.org/r/120940/diff/ > > > Testing > ------- > > Able to activate/deactivate parsing comments. When activated able to choose > specific sign > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
