> On Feb. 28, 2015, 12:20 a.m., Jarosław Staniek wrote: > > kexi/plugins/importexport/csv/kexicsvwidgets.cpp, line 199 > > <https://git.reviewboard.kde.org/r/120940/diff/4/?file=351936#file351936line199> > > > > Remove the checkbox, instead prepend the i18nc("No comment sign", > > "None") item to the combo (as the 1st item). > > Wojciech Kosowicz wrote: > How about keeping the checkbox?? I think it emphasizes the optional > nature of csv parsing
The less widgets, the better. Combo + checkbox is more complex logic to non-programmer than a single combo. We're using the "None" first item already in a few places and it's pretty common design pattern in the industry :) - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120940/#review76749 ----------------------------------------------------------- On Feb. 28, 2015, 7:15 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120940/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 7:15 p.m.) > > > Review request for Calligra, Adam Pigg and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > When hash sign (#) appears in csv file at the beginning of the line or in the > middle of unqouted field > it is treated as the beginning of the comment and the following data is being > ignored until the end of the row > > > Diffs > ----- > > kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4 > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285 > kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd > kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4 > libs/widgets/KoCsvImportDialog.cpp 8d042d7 > > Diff: https://git.reviewboard.kde.org/r/120940/diff/ > > > Testing > ------- > > Able to activate/deactivate parsing comments. When activated able to choose > specific sign > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
