-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122197/#review75376
-----------------------------------------------------------
Two more small fixes would be nice:
- When I click Next on "Alter the Detected Table Design" and then Back, Caption
and Name fields are reset. This shouldn't happen.
- On the last Success page please disable ability to click Back, otherwise user
may try to import twice what can't be performed.
And two improvements:
- On the last Success page add message i18n("Table <resource>%1</resource> has
been imported.")
- On the last Success page add an i18n("Open imported project") checkbox, OFF
by default; then open the imported table if checked. For similar code with
layout refer to ImportWizard::setupFinish(). How to open afterwards? We need to
pass the table name back from the plugin.
1. See KexiMainWindow::showProjectMigrationWizard() as example
2. In KexiMainWindow::slotToolsImportTables() you create QMap<QString, QString>
args; and pass as an arg to KexiInternalPart::createModalDialogInstance()
3. Look at ImportWizard::import() how
d->args->insert("destinationDatabaseName") is used after successfull import. We
need similarly, just the variable name could be "destinationTableName", right?
4. Back in KexiMainWindow::slotToolsImportTables() after the successful import
you receive the table name using args["destinationTableName"] and use
KexiMainWindow::openObject(const QString& partClass, const QString& name,
Kexi::ViewMode viewMode, bool).
- Jarosław Staniek
On Feb. 3, 2015, 1:26 p.m., Roman Shtemberko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122197/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 1:26 p.m.)
>
>
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and
> Wojciech Kosowicz.
>
>
> Bugs: 336815
> http://bugs.kde.org/show_bug.cgi?id=336815
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Fix 336815 (path issue)
> Also have fixed with this patch:
> Check for an empty name.
> Names are no more converted to the lower case (there is some conflicts with
> this behavior, imported tables can not be opened after this (only after
> restarting an app (!?)))
> Check if name is not starting with a digit (conflicts with '_' at the
> begining as well).
> Default name is added based on sheet selected.
>
>
> Diffs
> -----
>
> kexi/migration/AlterSchemaWidget.cpp ea7fedd
> kexi/migration/importtablewizard.h a0b4dca
> kexi/migration/importtablewizard.cpp f3d02b9
> kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e
> kexi/migration/AlterSchemaWidget.h b29e7f9
>
> Diff: https://git.reviewboard.kde.org/r/122197/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roman Shtemberko
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
