----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101129/#review3310 -----------------------------------------------------------
Ship it! Please fix the things I noted and then commit. Nice work kpresenter/part/KPrView.cpp <http://git.reviewboard.kde.org/r/101129/#comment2780> There should be a blank after the , kpresenter/part/KPrViewModeSlidesSorter.cpp <http://git.reviewboard.kde.org/r/101129/#comment2781> please change the variable name here as you shadow the member variable. - Thorsten On May 13, 2011, 3:43 p.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101129/ > ----------------------------------------------------------- > > (Updated May 13, 2011, 3:43 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Add save of zoom factor and mode for normal view and slides sorter. Also > eliminate page and width options of zooming in Slides Sorter (these options > doesn't make much sense in that view). > Finally I eliminate the white space around the slide because it make the > slide lost focus when zooming and when I restore the previous zoom value (the > zoom function center the white space too), in addition the white space make > too big the default size of shapes when inserted. > (I ask in calligra channel, and the white space was added to have an area for > insert things, maybe it could be added in a better way). > > > Diffs > ----- > > kpresenter/part/KPrView.h 80b67520be60500ecf11df0827f1d4ee8eeab4e7 > kpresenter/part/KPrView.cpp 0ba563aebc7fe7566b5cc00bbcabef235e48b317 > kpresenter/part/KPrViewModeSlidesSorter.h > ec5f6691072115eb7818f1eb224f6a03fe9bf13c > kpresenter/part/KPrViewModeSlidesSorter.cpp > b4fee3c755aebf65e9bff0cef5516776533ec4a6 > libs/kopageapp/KoPAView.h 5585364c4bf0503e312a302b91f762653aaf98bb > libs/kopageapp/KoPAView.cpp c53edecb309098949f66e9d50238bc60f26f9bee > > Diff: http://git.reviewboard.kde.org/r/101129/diff > > > Testing > ------- > > build and run > > > Thanks, > > Paul > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
