> On April 15, 2011, 3:03 a.m., Thorsten Zachmann wrote: > > Please don't remove the feature of having space around the slide just to > > make the new feature work. Try to fix the problem instead of removing the > > feature. > > How about centreing the canvas after loading? > > > > It is not a good idea to store view settings in the document as there can > > be more the one view. How about save the settings per view. Maybe only save > > it for the first view but the saving should be done inside the view and not > > inside the document as when opening only one view is visible. That would > > also avoid having this extra signal that was added.
Maybe your problem is fixed if the problem is fixed that I wrote about on the mailing list. - Thorsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101129/#review2654 ----------------------------------------------------------- On April 14, 2011, 10:53 p.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101129/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 10:53 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Add save of zoom factor and mode for normal view and slides sorter. Also > eliminate page and width options of zooming in Slides Sorter (these options > doesn't make much sense in that view). > Finally I eliminate the white space around the slide because it make the > slide lost focus when zooming and when I restore the previous zoom value (the > zoom function center the white space too), in addition the white space make > too big the default size of shapes when inserted. > (I ask in calligra channel, and the white space was added to have an area for > insert things, maybe it could be added in a better way). > > > Diffs > ----- > > kpresenter/part/KPrDocument.h 30bfae0ccee8e4a3775b9629358102bbe85cd6ad > kpresenter/part/KPrDocument.cpp 1d94bb97cbfe0b6922290aa00f38191616feaff4 > kpresenter/part/KPrView.h 80b67520be60500ecf11df0827f1d4ee8eeab4e7 > kpresenter/part/KPrView.cpp aef56d9fcb919a314f0095629bea1927916f8059 > kpresenter/part/KPrViewModeSlidesSorter.h > ec5f6691072115eb7818f1eb224f6a03fe9bf13c > kpresenter/part/KPrViewModeSlidesSorter.cpp > b4fee3c755aebf65e9bff0cef5516776533ec4a6 > libs/kopageapp/KoPAView.cpp c53edecb309098949f66e9d50238bc60f26f9bee > > Diff: http://git.reviewboard.kde.org/r/101129/diff > > > Testing > ------- > > build and run > > > Thanks, > > Paul > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
