> On April 17, 2011, 11:19 a.m., Thorsten Zachmann wrote: > > Would it be enough to save the zoom in the destructor of the KPrView and > > KPrViewModeSlidesSorter? Then it is only written once and not with every > > change which will also save resources. Also it will make the code simpler. > > Paul Mendez wrote: > It could work if I store only one zoom value. I have been trying to store > the zoom value for normal view and other for slides sorter view. As both > views are destroyed at the same time, It would store the zoom value used in > the last view visible, and then restore it as the default value for all > views. > I am going to try, moving the store code to the deactivate function of > the slides sorter view, but I am not sure if that work when you close the > program while you are still in the slides sorter view. I will write the > result later.
If you save the zoom values for the slide sorter inside it you could save that. But the deactivate code is fine too in my oppinion. - Thorsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101129/#review2698 ----------------------------------------------------------- On April 16, 2011, 8:45 p.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101129/ > ----------------------------------------------------------- > > (Updated April 16, 2011, 8:45 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Add save of zoom factor and mode for normal view and slides sorter. Also > eliminate page and width options of zooming in Slides Sorter (these options > doesn't make much sense in that view). > Finally I eliminate the white space around the slide because it make the > slide lost focus when zooming and when I restore the previous zoom value (the > zoom function center the white space too), in addition the white space make > too big the default size of shapes when inserted. > (I ask in calligra channel, and the white space was added to have an area for > insert things, maybe it could be added in a better way). > > > Diffs > ----- > > kpresenter/part/KPrView.h 80b67520be60500ecf11df0827f1d4ee8eeab4e7 > kpresenter/part/KPrView.cpp aef56d9fcb919a314f0095629bea1927916f8059 > kpresenter/part/KPrViewModeSlidesSorter.h > ec5f6691072115eb7818f1eb224f6a03fe9bf13c > kpresenter/part/KPrViewModeSlidesSorter.cpp > b4fee3c755aebf65e9bff0cef5516776533ec4a6 > libs/kopageapp/KoPAView.cpp c53edecb309098949f66e9d50238bc60f26f9bee > > Diff: http://git.reviewboard.kde.org/r/101129/diff > > > Testing > ------- > > build and run > > > Thanks, > > Paul > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
