Paul Eggert wrote:
> Thanks for the careful review. I installed the patch with the 
> corrections you suggested, along with another fix to lib/backupfile.c 
> (where my patch had an obvious blunder), one more strcmp->streq change 
> in lib/setlocale.c, and some minor indenting fixups.

A small followup patch:
1) Add a copyright notice, so that when this file gets copied into
   package tarballs, Ineiev can't complain like he did in
   <https://savannah.gnu.org/bugs/?54809>.
2) #include_next works better if we use <string.h>, not "string.h".
   See 
https://www.gnu.org/software/gnulib/manual/html_node/Style-of-_0023include-statements.html


2025-09-17  Bruno Haible  <[email protected]>

        Add copyright notices.
        * lib/string.c: Add copyright notice. Use <string.h>, not "string.h".

diff --git a/lib/string.c b/lib/string.c
index 9427275a3c..cce2eac9c0 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -1,3 +1,20 @@
+/* streq and memeq functions.
+   Copyright (C) 2025 Free Software Foundation, Inc.
+
+   This file is free software: you can redistribute it and/or modify
+   it under the terms of the GNU Lesser General Public License as
+   published by the Free Software Foundation; either version 2.1 of the
+   License, or (at your option) any later version.
+
+   This file is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public License
+   along with this program.  If not, see <https://www.gnu.org/licenses/>.  */
+
 #include <config.h>
+
 #define _GL_STRING_INLINE _GL_EXTERN_INLINE
-#include "string.h"
+#include <string.h>




Reply via email to