> Le 25 nov. 2018 à 18:02, Akim Demaille <a...@lrde.epita.fr> a écrit :
>
> Hi Bruno!
>
>> * File names are nowadays not limited to 8+3 characters, and names
>> like 'abitset.h', 'bbitset.h', 'ebitset.h', 'lbitset.h', 'vbitset.h'
>> are not really telling. How about using more descriptive names?
>> Note: You can use subdirectories to keep files grouped together,
>> especially since the only file the user sees is bitset.h.
>> How about renaming e.g.
>> abitset.[hc] -> bitset/array.[hc]
>> lbitset.[hc] -> bitset/list.[hc]
>> and keeping only bitset.h at the top level?
>
> Fine with me!
There was the problem of vbitset.[ch], labeled as "variable array bitsets". I
disliked 'bitset/variable.h' because it's misleading, and does not look
balanced in front of 'bitset/array.h' which is not named 'bitset/fixed.h'. So,
as a C++ developer, I went for 'bitset/vector.h': same initial, and clear
meaning (to me?).
But now we also have the bitset vectors. Currently bitset/ is only about
implementation details, so I don't think bitset vectors should be part of
bitset/. I would be fine with bitsetv.[ch], as is currently the case, but
maybe you have a different opinion. Of course it could be bitset-vector.[ch].
Or completely change: all the bitsets of a bitsetv have the same dimension, so
we could go to bitmatrix. Which has the unfortunate consequence of making the
link between both modules looser.
