On Thu, 2017-01-05 at 20:15 +0100, Bruno Haible wrote: > Torvald Riegel wrote: > > I found two bugs just by briefly scanning through the current > > lib/glthread/lock.c. As a hint, I'll just mention double-checked > > locking and order of destruction. And skipping destruction is of course > > not correct in the general case either (unless I'm misreading > > lib/glthread/cond.c, for example). > > Can you give line numbers, please? lib/glthread/lock.c and lib/glthread/cond.c > are large files. If you have found bugs there, *of course* I want to have > them fixed.
I can understand both points. However, I'd suggest that you first try to find them (or that whoever maintains these files does); this is often a good exercise, and helps make oneself sensitive for concurrency problems. If you don't want to do that first, I can give details.
