On Mon, Mar 14, 2011 at 03:32:48AM +0100, Heiko Baums wrote:
> Could the reason be some syntax errors?
> There are a lot of quotation marks too much. And the settings of your
> quotation marks seem to be quite inconsistent.
> 
> > build() {
> >   cd "${srcdir}/$pkgname-$pkgver"
> Better: cd ${srcdir}/$pkgname-$pkgver
> 
> > package() {
> >   cd "${srcdir}/$pkgname-$pkgver"
> Better: cd ${srcdir}/$pkgname-$pkgver
> 
> >   make prefix="${pkgdir}"/usr install
> Better: make prefix=${pkgdir}/usr install
> 
> >   install -D -d -m755 "${pkgdir}"/usr/share
> Better: install -D -d -m755 ${pkgdir}/usr/share
> 
> >   install -D -m644 "${srcdir}/$pkgname-$pkgver"/COPYING \
> >     "${pkgdir}"/usr/share/licenses/"${pkgname}"/LICENSE
> Better: install -D -m644 ${srcdir}/$pkgname-$pkgver/COPYING
> ${pkgdir}/usr/share/licenses/$pkgname/LICENSE
> 
> Heiko

s/Better/Worse/

Inconsistant quoting is better than not quoting at all. If someone's
$srcdir expand with a space in it, the build breaks.

dave

Reply via email to