----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103960/#review10650 -----------------------------------------------------------
Ship it! Except for that one capital 'O' it's perfect and can be merged. Very good work Jasneet. I'd be more then happy to review more junior jobs from you. src/MainWindow.cpp <http://git.reviewboard.kde.org/r/103960/#comment8683> Minor nitpick. When using title capitalization the words with < 4 chars are not capitalized. http://techbase.kde.org/Projects/Usability/HIG/Capitalization. - Bart Cerneels On Feb. 15, 2012, 3:09 a.m., Jasneet Bhatti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103960/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2012, 3:09 a.m.) > > > Review request for Amarok. > > > Description > ------- > > This patch fixes the bug : https://bugs.kde.org/show_bug.cgi?id=173814 > > I've created a new slot that is called when the key combination is pressed. > This slot in turn calls the concerned function to display Edit Track Details > dialog. > > > Diffs > ----- > > src/MainWindow.h 984aa28 > src/MainWindow.cpp ea99659 > src/playlist/PlaylistDock.h 897be1d > src/playlist/PlaylistDock.cpp b217e3c > > Diff: http://git.reviewboard.kde.org/r/103960/diff/ > > > Testing > ------- > > I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work > fine. > > > Thanks, > > Jasneet Bhatti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
