----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103960/#review10581 -----------------------------------------------------------
This change looks good to me. I cannot test right now, do I assume correctly that the shortcut appears in Settings -> Configure chortcuts? src/MainWindow.cpp <http://git.reviewboard.kde.org/r/103960/#comment8654> I assume this edits details of currently playing (or currently selected?) song. I would include the fact in action description. src/playlist/PlaylistDock.cpp <http://git.reviewboard.kde.org/r/103960/#comment8652> Is there any specific reason this call is here? - Matěj Laitl On Feb. 13, 2012, 5:26 a.m., Jasneet Bhatti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103960/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2012, 5:26 a.m.) > > > Review request for Amarok. > > > Description > ------- > > This patch fixes the bug : https://bugs.kde.org/show_bug.cgi?id=173814 > > I've created a new slot that is called when the key combination is pressed. > This slot in turn calls the concerned function to display Edit Track Details > dialog. > > > Diffs > ----- > > src/MainWindow.h 984aa28 > src/MainWindow.cpp ea99659 > src/playlist/PlaylistDock.h 897be1d > src/playlist/PlaylistDock.cpp b217e3c > > Diff: http://git.reviewboard.kde.org/r/103960/diff/ > > > Testing > ------- > > I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work > fine. > > > Thanks, > > Jasneet Bhatti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
