> On Feb. 13, 2012, 8:40 a.m., Matěj Laitl wrote: > > This change looks good to me. I cannot test right now, do I assume > > correctly that the shortcut appears in Settings -> Configure chortcuts?
Yes, it does appear in Settings->Configure shortcuts. > On Feb. 13, 2012, 8:40 a.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 774 > > <http://git.reviewboard.kde.org/r/103960/diff/1/?file=49410#file49410line774> > > > > I assume this edits details of currently playing (or currently > > selected?) song. I would include the fact in action description. It's editing the details of the currently selected track, not the one currently playing. So do you mean that it should look like : action = new KAction( KIcon("media-track-edit-amarok"), i18n("Edit Details Of Currently Selected Track"), this ); > On Feb. 13, 2012, 8:40 a.m., Matěj Laitl wrote: > > src/playlist/PlaylistDock.cpp, line 327 > > <http://git.reviewboard.kde.org/r/103960/diff/1/?file=49412#file49412line327> > > > > Is there any specific reason this call is here? I was unable to completely understand it's role. It was apparently working fine without the call but I added it because it was there in all the other member function definitions, so I figured that it must be important. - Jasneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103960/#review10581 ----------------------------------------------------------- On Feb. 13, 2012, 5:26 a.m., Jasneet Bhatti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103960/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2012, 5:26 a.m.) > > > Review request for Amarok. > > > Description > ------- > > This patch fixes the bug : https://bugs.kde.org/show_bug.cgi?id=173814 > > I've created a new slot that is called when the key combination is pressed. > This slot in turn calls the concerned function to display Edit Track Details > dialog. > > > Diffs > ----- > > src/MainWindow.h 984aa28 > src/MainWindow.cpp ea99659 > src/playlist/PlaylistDock.h 897be1d > src/playlist/PlaylistDock.cpp b217e3c > > Diff: http://git.reviewboard.kde.org/r/103960/diff/ > > > Testing > ------- > > I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work > fine. > > > Thanks, > > Jasneet Bhatti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
