----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/#review10263 -----------------------------------------------------------
src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <http://git.reviewboard.kde.org/r/100998/#comment8445> Does this query produce results that are correctly ordered by pubDate? The order by seems to only apply to the 2nd SELECT after UNION. src/core/podcasts/PodcastMeta.h <http://git.reviewboard.kde.org/r/100998/#comment8444> Why is this method in the base class. I doubt episode-keeping is something generic that will be present in all podcast implementations, hence the isKeep method, the QAction, etc should only be in SqlPodcastProvider. To further make my point: isKeep will ensure the episode remains visible even when purge is enabled. Episode purging is specific to SqlPodcastProvider. - Bart Cerneels On Jan. 31, 2012, 1:20 a.m., Lucas Gomes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100998/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2012, 1:20 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked. > These "kept" episodes are shown in the list regardless of the purgecount, > even if they > are not downloaded. > > BUG Description: > > Currently downloaded files are not kept when the episode is no longer shown in > the Podcast section. This behavior can not be configured but is tied to the > purge settings of each channel. > > It's possible to add a "keep downloaded file" checkbox to episodes to prevent > the deletion from happening. We should perhaps also show these "kept" episodes > in the list regardless of the purgecount. So even if a channel has purgecount > 5 > and 3 episodes marked to keep it will show 5 + maximum 3 older kept episodes. > > Reproducible: Always > > > This addresses bug 261062. > https://bugs.kde.org/show_bug.cgi?id=261062 > > > Diffs > ----- > > src/browsers/playlistbrowser/PodcastModel.h e88f4a1 > src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 > src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 > src/core-impl/podcasts/sql/SqlPodcastProvider.h c3d5e56 > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f > src/core/podcasts/PodcastMeta.h 679f7ac > src/playlistmanager/SyncedPodcast.h c186df2 > > Diff: http://git.reviewboard.kde.org/r/100998/diff/diff > > > Testing > ------- > > > Thanks, > > Lucas Gomes > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
