On 10/30/11 15:19, Peter Hutterer wrote:
On Sat, Oct 29, 2011 at 12:36:53AM -0700, Jeremy Huddleston wrote:
Reviewed-by: Jeremy Huddleston<[email protected]>
Why does xi2 "need" -wrap? Can we do these tests in a more portable way
with some clever macros?
It'd be easier to just disable the tests on the platforms that don't have
-wrap. The last thing we need is making tests harder to write.
Which is what we currently do, this just allows the others to be available
on other platforms (though it needs a macros patch to be fully effective,
I'll send out a revised version soon).
all but one test in xi2 needs -wrap, but I don't see any other check there.
test/xi2/Makefile.am is already wrapped in
if ENABLE_UNIT_TESTS
if HAVE_LD_WRAP
[...]
endif
endif
and I was leaving that one, which seemed sufficient (at least on Solaris,
where it currently detects ld -wrap is not available, due to another issue,
this allowed the tests in tests/*.c to run, and skipped tests/Xi/*.c).
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
