> From: =?UTF-8?q?Erkki=20Sepp=C3=A4l=C3=A4?= <[email protected]>
> Date: Thu, 27 Jan 2011 09:53:44 +0200
>
> Reordered code to first to do the comparison and then to release data
Your static analysis tool isn't all that good. Using the value of a
pointer after freeing the storage it points to is totally fine.
> ---
> src/XlibInt.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/XlibInt.c b/src/XlibInt.c
> index d55c26a..c385f4c 100644
> --- a/src/XlibInt.c
> +++ b/src/XlibInt.c
> @@ -777,10 +777,10 @@ _XFreeEventCookies(Display *dpy)
> head = (struct stored_event**)&dpy->cookiejar;
>
> DL_FOREACH_SAFE(*head, e, tmp) {
> - XFree(e->ev.data);
> - XFree(e);
> if (dpy->cookiejar == e)
> dpy->cookiejar = NULL;
> + XFree(e->ev.data);
> + XFree(e);
> }
> }
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
