On Wed, Sep 15, 2010 at 4:12 AM, Tormod Volden <[email protected]> wrote:
> On Wed, Sep 15, 2010 at 7:56 AM, Trevor Woerner wrote:
>>
>> - if [ "$1" = "lib" ] && [ "$2" = "libX11" ] && [ x"$USE_XCB" = xNO ];
>> then
>> + if [ "$1" = "lib" ] && [ "$2" = "libX11" ] && [ "x${USE_XCB}" = "xNO"
>> ]; then
>> MOD_SPECIFIC="--with-xcb=no"
>> fi
>
> Any reason to not write just [ "$USE_XCB" = "NO" ] ? Then we could get
> of all these x$checks, they are sooo 70's :)
I have never questioned that one before. I've seen it done so often I
just assumed there was a good reason for it. But after doodling around
with a test script for a while I can't seem to see why the string
delimiters would be necessary. Does anyone know why "USE_XCB" = "NO"
wouldn't be good enough?
>> ${MAKE} $MAKEFLAGS || failed make $1 $2
>
> (and many other places)
>
> For consistency, maybe get rid of unnecessary braces?
Ha ha, yes, I agree! I especially stumbled over that one when I
reviewed the following line:
if [ -z "${PREFIX}" ] && [ -z "$LISTONLY" ]; then
That would have to be a separate patch, though, since there are places
where this brace cleanup would be needed which aren't in conditionals.
I'll start working on one.
Best regards,
Trevor
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
