Hi Julien,
> On 19 Nov 2020, at 19:07, Julien Grall <[email protected]> wrote:
>
> From: Julien Grall <[email protected]>
>
> discard_init_modules() is an init function, if the path contains a
> BUG() or WARN() we still want to get the full stack trace.
>
> The init virtual region is now kept after the last init function has
> been called.
>
> Signed-off-by: Julien Grall <[email protected]>
Reviewed-by: Bertrand Marquis <[email protected]>
Cheers
Bertrand
> ---
> xen/arch/arm/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 7fcff9af2a7e..2532ec973913 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -72,10 +72,11 @@ domid_t __read_mostly max_init_domid;
>
> static __used void init_done(void)
> {
> + discard_initial_modules();
> +
> /* Must be done past setting system_state. */
> unregister_init_virtual_region();
>
> - discard_initial_modules();
> free_init_memory();
> startup_cpu_idle_loop();
> }
> --
> 2.17.1
>