Hi Julien,
> On 19 Nov 2020, at 19:07, Julien Grall <[email protected]> wrote:
>
> From: Julien Grall <[email protected]>
>
> The ; at the end of mm_printk() means the following code will not build
> correctly:
>
> if ( ... )
> mm_printk(...);
> else
> ...
>
> As we treat the macro as a function, we want to remove the ; at the end
> of it.
>
> Signed-off-by: Julien Grall <[email protected]>
Reviewed-by: Bertrand Marquis <[email protected]>
Cheers
Bertrand
> ---
> xen/arch/arm/mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 4dd886f7c80d..59f8a3f15fd1 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -59,7 +59,7 @@ mm_printk(const char *fmt, ...) {}
> { \
> dprintk(XENLOG_ERR, fmt, ## args); \
> WARN(); \
> - } while (0);
> + } while (0)
> #endif
>
> /*
> --
> 2.17.1
>
>