On 06.11.2019 23:08, Artem Mygaiev wrote: > On Wed, Nov 6, 2019 at 4:28 PM Jan Beulich <[email protected]> wrote: >> On 06.11.2019 10:19, Andrii Anisov wrote: >>> --- a/Config.mk >>> +++ b/Config.mk >>> @@ -221,7 +221,9 @@ CFLAGS += -Wall -Wstrict-prototypes >>> >>> $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement) >>> $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement) >>> +ifneq ($(armds),y) >>> $(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable) >>> +endif >>> $(call cc-option-add,CFLAGS,CC,-Wno-unused-local-typedefs) >>> >>> LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i)) >> >> ... this would be necessary. > > I am very sorry, this patch does not have a proper description indeed. > > For this particular change - arm clang does not undestand > -Wno-unused-but-set-variable > option at all, that is why it is under !$(armds)
But avoiding to add options which the compiler doesn't understand is the purpose of using cc-option-add, rather than blindly adding them to CFLAGS. What am I missing here? Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
