> -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: 13 September 2019 11:05 > To: Paul Durrant <[email protected]> > Cc: [email protected]; Julien Grall <[email protected]>; > Andrew Cooper > <[email protected]>; Roger Pau Monne <[email protected]>; > Volodymyr Babchuk > <[email protected]>; George Dunlap <[email protected]>; Ian > Jackson > <[email protected]>; Stefano Stabellini <[email protected]>; Konrad > Rzeszutek Wilk > <[email protected]>; Tim (Xen.org) <[email protected]>; Wei Liu <[email protected]> > Subject: Re: [PATCH v10 5/6] iommu: tidy up iommu_use_hap_pt() and > need_iommu_pt_sync() macros > > On 13.09.2019 11:47, Paul Durrant wrote: > > --- a/xen/include/xen/iommu.h > > +++ b/xen/include/xen/iommu.h > > @@ -56,8 +56,10 @@ extern bool_t iommu_enable, iommu_enabled; > > extern bool_t force_iommu, iommu_verbose, iommu_igfx; > > extern bool_t iommu_snoop, iommu_qinval, iommu_intremap, iommu_intpost; > > > > -#ifdef CONFIG_HVM > > +#if defined(CONFIG_HVM) > > extern bool iommu_hap_pt_share; > > +#elif defined(CONFIG_IOMMU_FORCE_PT_SHARE) > > +#define iommu_hap_pt_share true > > #else > > #define iommu_hap_pt_share false > > #endif > > The ordering is wrong here - Arm unconditionally defines HVM, and > hence it now also setting IOMMU_FORCE_PT_SHARE won't be accounted > for this way. I'd be happy to adjust this on commit, but I'm afraid > I'm still unhappy about patch 3 (but I guess at this point I'll > better propose a replacement than ask you for going through another > round). >
Actually I'm going to send a v11 anyway, as there are issues with the abi-check (now that Ian has fixed the script). Paul > Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
