On 13.09.2019 11:47, Paul Durrant wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -56,8 +56,10 @@ extern bool_t iommu_enable, iommu_enabled; > extern bool_t force_iommu, iommu_verbose, iommu_igfx; > extern bool_t iommu_snoop, iommu_qinval, iommu_intremap, iommu_intpost; > > -#ifdef CONFIG_HVM > +#if defined(CONFIG_HVM) > extern bool iommu_hap_pt_share; > +#elif defined(CONFIG_IOMMU_FORCE_PT_SHARE) > +#define iommu_hap_pt_share true > #else > #define iommu_hap_pt_share false > #endif
The ordering is wrong here - Arm unconditionally defines HVM, and hence it now also setting IOMMU_FORCE_PT_SHARE won't be accounted for this way. I'd be happy to adjust this on commit, but I'm afraid I'm still unhappy about patch 3 (but I guess at this point I'll better propose a replacement than ask you for going through another round). Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
