Jan Beulich <[email protected]> wrote: > On 26.02.2026 15:29, Bernhard Kaindl wrote: > > > > Also change total_avail_pages and outstanding_claims to unsigned long: > > > > Those never become negative (we protect that with ASSERT/BUG_ON already), > > and converting them to unsigned long makes that explicit, and also > > fixes signed/unsigned comparison warnings. > > This wants to be a separate commit. It hasn't got anything to do in here.
Ok. > > This only needs moving the ASSERT to before the subtraction. > > See the previous commit moving the BUG_ON for outstanding_claims. > > Please can you avoid such statements? You won't know in which order the > patches are committed: Patch 01 may go in weeks or months before patch > 02. Thanks, ok, will remove. - NB. I do think the first 3 commits should best be applied in one go. > > +#define node_avail_pages(node) (node_avail_pages[node]) > > This isn't really needed when ... > > > +static unsigned long node_avail_pages[MAX_NUMNODES]; > > ... it's a static array anyway. Plus you may want to talk to Andrew regarding > the use of such a macro as an lvalue. Ok. It was only a controlled, local accessor in this file to support moving it to another storage variable, but I'll omit the accessor macro(s) then. > > +/* total outstanding claims by all domains */ > > +static unsigned long outstanding_claims; > > As you touch it, comment style wants correcting. I guess you mean to uppercase the 1st letter of the comment. Will do. Bernhard
