On 10/29/25 15:57, Jan Beulich wrote:
> On 29.10.2025 14:38, Dmytro Prokopchuk1 wrote:
>> These files 'docs/misc/kconfig{,-language}.txt' were deleted, but
>> references are still present in Xen. Remove them to clean-up.
>>
>> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
>
> Hmm, that commit replaced the .txt files with .rst ones, so maybe you want a
> 2nd tag here referencing 044503f61c95 ("docs: Delete kconfig docs to fix
> licensing violation")?
Well, I saw that commit, but intentionally selected first one.
Looks like commit 044503f61c95 is more appropriate.> >> --- a/INSTALL >> +++ b/INSTALL >> @@ -23,7 +23,7 @@ Xen Hypervisor >> ============== >> >> Xen itself is configured via a `kconfig' system borrowed from Linux. >> -See docs/misc/kconfig.txt. >> +See https://www.kernel.org/doc/html/latest/kbuild/. > > Is linking to "latest" doc really appropriate, when we don't even try to stay > up-to-date? That's what Andrew's commit suggests, but I dare to question this. If the kconfig directory was imported from the Linux kernel v5.4, I think the following link is OK: https://www.kernel.org/doc/html/v5.4/kbuild/ > >> --- a/xen/Kconfig >> +++ b/xen/Kconfig >> @@ -1,6 +1,6 @@ >> # >> # For a description of the syntax of this configuration file, >> -# see docs/misc/kconfig-language.txt >> +# see https://www.kernel.org/doc/html/latest/kbuild/ > > Maybe more specifically > https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html > at least here (with latest possibly replaced as per above)? > > Jan and here: https://www.kernel.org/doc/html/v5.4/kbuild/kconfig-language.html Dmytro.
