"struct segment_register" requires a prior inclusion of x86_emulate.h, and it's missing a forward declaration of "struct vcpu" too.
Sort these out so the header can be included by itself. Not a functional change. Signed-off-by: Alejandro Vallejo <[email protected]> --- This dependency already exists today. I'm just making it explicit. "segment_register" is weird. It naturally belongs in vmcb.h, but the emulator makes use of it and must be compilable outside of Xen. I don't like having vmcb.h depending on the emulator header, but I see no way of breaking that dependency without breaking the emulator unit tests. --- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index 28f715e376..7c599a1c39 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -10,6 +10,10 @@ #include <xen/types.h> +#include <asm/x86_emulate.h> /* for "struct segment_register" */ + +struct vcpu; + /* general 1 intercepts */ enum GenericIntercept1bits { base-commit: b6fc307b0b00314d4e4460fcf8be2cd9e4ff8652 -- 2.43.0
