On 06/10/2025 12:29 pm, Alejandro Vallejo wrote: > On Mon Oct 6, 2025 at 1:04 PM CEST, Andrew Cooper wrote: >> On 06/10/2025 11:46 am, Alejandro Vallejo wrote: >>> --- >>> This dependency already exists today. I'm just making it explicit. >>> >>> "segment_register" is weird. It naturally belongs in vmcb.h, but the >>> emulator makes use of it and must be compilable outside of Xen. >>> >>> I don't like having vmcb.h depending on the emulator header, but I see >>> no way of breaking that dependency without breaking the emulator unit >>> tests. >> Pulling it into a new header is fine. The emulator can include anything >> (free-enough standing) in arch/x86/include/asm/ > I thought it didn't, if so I'm at a loss at to why segment_register is where > it is.
Well - it's needed by the emulator as well as SVM. > > Be that as it may, your series conflicts with this patch and it makes no sense > to keep both around (when none of them are going in for until 4.22). > > Will you be including a fix for the segment register in your series also? If > so, > I'll just drop this one. I've folded the extra include into my first patch. ~Andrew
