On 18.09.25 17:59, Jan Beulich wrote:
> On 18.09.2025 14:16, Mykyta Poturai wrote:
>> --- a/config/arm64.mk
>> +++ b/config/arm64.mk
>> @@ -1,5 +1,6 @@
>>   CONFIG_ARM := y
>>   CONFIG_ARM_64 := y
>> +CONFIG_HOTPLUG := y
>>   
>>   CONFIG_XEN_INSTALL_SUFFIX :=
>>   
>> --- a/config/x86_32.mk
>> +++ b/config/x86_32.mk
>> @@ -3,6 +3,7 @@ CONFIG_X86_32 := y
>>   
>>   CONFIG_MIGRATE := y
>>   CONFIG_XCUTILS := y
>> +CONFIG_HOTPLUG := y
>>   
>>   CFLAGS += -m32 -march=i686
>>   
>> --- a/config/x86_64.mk
>> +++ b/config/x86_64.mk
>> @@ -3,6 +3,7 @@ CONFIG_X86_64 := y
>>   
>>   CONFIG_MIGRATE := y
>>   CONFIG_XCUTILS := y
>> +CONFIG_HOTPLUG := y
>>   
>>   CONFIG_XEN_INSTALL_SUFFIX := .gz
> 
> I realize you only do what is already being done, but I question this
> way of doing things when the scope is tools-only. Any CONFIG_* put here
> cannot have an identically named, but potentially set differently
> Kconfig setting in xen/: Any use of such in a Makefile could end up being
> wrong, and would pretty surely end up being confusing.
> 
> Jan

I have checked the whole codebase and didn't find any other 
CONFIG_HOTPLUG, the only similar thing is CONFIG_HOTPLUG_CPU. Anyway, I 
can change it to something more specific like CONFIG_HPTOOL for example.

-- 
Mykyta

Reply via email to