> -----Original Message-----
> From: Jan Beulich [mailto:[email protected]]
> Sent: Tuesday, July 3, 2018 3:12 PM
> To: Xin Li <[email protected]>
> Cc: Andrew Cooper <[email protected]>; Ming Lu
> <[email protected]>; Sergey Dyasli <[email protected]>; Wei Liu
> <[email protected]>; Xin Li (Talons) <[email protected]>; George Dunlap
> <[email protected]>; Stefano Stabellini <[email protected]>; xen-
> [email protected]; Konrad Rzeszutek Wilk <[email protected]>; Daniel
> de Graaf <[email protected]>; Tim (Xen.org) <[email protected]>
> Subject: Re: [PATCH 1/2] xen/xsm: Introduce new boot parameter xsm
>
> First of all - please indicate the version also in the subject, i.e. here
> [PATCH v2
> 1/2] or some such.
>
> >>> On 03.07.18 at 03:26, <[email protected]> wrote:
> > v2
> > To further discuss:
> > 1) is "dummy" a good command line option?
> > other choices: basic", "trivial", or "simple"
>
> Indeed, but not limited to the named set.
>
> Additionally, please have a brief summary of changes from the prior version
> here.
>
> > + switch ( xsm_bootparam )
> > + {
> > + case XSM_BOOTPARAM_DUMMY:
> > + break;
> > +
> > + case XSM_BOOTPARAM_FLASK:
> > + flask_init(policy_buffer, policy_size);
> > + break;
> > +
> > + default:
> > + printk("XSM: Invalid value for xsm= boot parameter.\n");
>
> As I think I've said before - generally no full stop at the end of log
> messages
> please. I also think that in error messages like this the offending string
> should
> be logged as well. Which points out an issue with the change: Without
> CONFIG_XSM_FLASK (under the current naming as proposed by Andrew; you
> should btw continue to name the dependency of your series on his one until
> that prereq has landed in staging, which you'd ideally do in a 0/2 cover
> letter) would perhaps better result in this error message to be issued, in
> favor
> of or in addition to the command line parsing one.
OK.
Remove this ".",
And in parse_xsm_param, add:
else {
printk("XSM: can't parse boot parameter xsm=%s\n", s);
rc = -EINVAL;
}
>
> Jan
>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
