On 09.07.2024 04:47, Chen, Jiqian wrote: > On 2024/7/8 22:56, Jan Beulich wrote: >> On 08.07.2024 13:41, Jiqian Chen wrote: >>> When a device has been reset on dom0 side, the Xen hypervisor >>> doesn't get notification, so the cached state in vpci is all >>> out of date compare with the real device state. >>> >>> To solve that problem, add a new hypercall to support the reset >>> of pcidev and clear the vpci state of device. So that once the >>> state of device is reset on dom0 side, dom0 can call this >>> hypercall to notify hypervisor. >>> >>> Signed-off-by: Jiqian Chen <[email protected]> >>> Signed-off-by: Huang Rui <[email protected]> >>> Signed-off-by: Jiqian Chen <[email protected]> >>> Reviewed-by: Stewart Hildebrand <[email protected]> >>> Reviewed-by: Stefano Stabellini <[email protected]> >> >> Reviewed-by: Jan Beulich <[email protected]> > Thank you very much! > >> >> Just to double check: You're sure the other two R-b are still applicable, >> despite the various changes that have been made? > Will remove in next version. > >> >> As a purely cosmetic remark: I think I would have preferred if the new >> identifiers didn't have "state" as a part; I simply don't think this adds >> much value, while at the same time making these pretty long. > Do you mean: remove "state" identifier on all the new codes?
"part of identifiers", yes. As that's a personal view, I wouldn't insist though, unless others shared my perspective. Jan
