On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/smp.h > @@ -0,0 +1,23 @@ > +#ifndef __ASM_RISCV_SMP_H > +#define __ASM_RISCV_SMP_H > + > +#ifndef __ASSEMBLY__ > +#include <xen/cpumask.h> > +#include <xen/percpu.h> > +#endif
If you want this to be possible to include from assembly files (I don't know why you would want that), ... > +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); > +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); ... these two would also need to live inside the #ifdef. Otherwise the #ifdef wants dropping. > +#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) Seeing this is now the 4th instance, I guess we want to move it to xen/smp.h. I'll try to remember making a patch. > +/* > + * Do we, for platform reasons, need to actually keep CPUs online when we > + * would otherwise prefer them to be off? > + */ > +#define park_offline_cpus false > + > +/* TODO: need to be implemeted */ > +#define smp_processor_id() (0) > + > +#endif > \ No newline at end of file You want to take care of this. Jan
