On 20.11.2023 15:56, Andrew Cooper wrote: > @@ -798,11 +799,11 @@ ept_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t > mfn, > unsigned int i, target = order / EPT_TABLE_ORDER; > unsigned long fn_mask = !mfn_eq(mfn, INVALID_MFN) ? (gfn | mfn_x(mfn)) : > gfn; > int ret, rc = 0; > - bool_t entry_written = 0; > - bool_t need_modify_vtd_table = 1; > - bool_t vtd_pte_present = 0; > + bool entry_written = false; > + bool need_modify_vtd_table = true; > + bool vtd_pte_present = false; > unsigned int iommu_flags = p2m_get_iommu_flags(p2mt, p2ma, mfn); > - bool_t needs_sync = 1; > + bool needs_sync = false;
Coverity has just (indirectly) spotted this mistake. I hope no others are lurking anywhere. Jan
