On 20/11/2023 4:17 pm, Jan Beulich wrote: > On 20.11.2023 15:56, Andrew Cooper wrote: >> ... as part of cleaning up the types used. Minor style cleanup on some >> altered lines. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <[email protected]> > Acked-by: Jan Beulich <[email protected]>
Thanks. > > One small request and a nit, though: > >> --- a/xen/arch/x86/include/asm/apic.h >> +++ b/xen/arch/x86/include/asm/apic.h >> @@ -139,7 +139,7 @@ static __inline void apic_icr_write(u32 low, u32 dest) >> } >> } >> >> -static __inline bool_t apic_isr_read(u8 vector) >> +static __inline bool apic_isr_read(u8 vector) > Would be nice to also switch to uint8_t at this occasion. > >> --- a/xen/arch/x86/include/asm/hvm/io.h >> +++ b/xen/arch/x86/include/asm/hvm/io.h >> @@ -54,7 +54,7 @@ typedef int (*hvm_io_write_t)(const struct hvm_io_handler >> *handler, >> uint64_t addr, >> uint32_t size, >> uint64_t data); >> -typedef bool_t (*hvm_io_accept_t)(const struct hvm_io_handler *handler, >> +typedef bool (*hvm_io_accept_t)(const struct hvm_io_handler *handler, >> const ioreq_t *p); > Nit: Failed to re-indent the 2nd line. I'll fix both. ~Andrew
