Hi Luca, > On 13 Nov 2023, at 10:58, Luca Fancellu <[email protected]> wrote: > >> >>> >>> The functions allocate_static_memory and assign_static_memory_11 >>> are now externally visible, so put their declarations into >>> domain_build.h and move the #else and stub definition in the header >>> as well. >>> >>> Move is_dom0less_mode from setup.c to dom0less-build.c and make it >>> externally visible. >>> >>> The function allocate_bank_memory is used only by dom0less code >>> at the moment, but it's been decided to leave it in domain_build.c >>> in case that in the future the dom0 code can use it. >>> >>> Where spotted, fix code style issues. >>> >>> No functional change is intended. >>> >>> Signed-off-by: Luca Fancellu <[email protected]> >>> --- >>> Changes from v2: >>> - move allocate_bank_memory back in domain_build.c, remove header >>> from dom0less-build.c. >> I can see you removed the copyright from .c but .h still has it. This also >> applies to other newly introduced files that were subject only to code >> movement. > > I’ve just read again your comment, I pushed the v4 but removing the header > only from > dom0less-build.h. > I left the header in the other static-* because that I think was code > produced by Arm, > please let me know your thoughts about that (you and the Arm maintainers)
Even if true, adding the copyright after is a bit odd. I do not think this is code on which the copyright really has impact so I would not add it during the move. Cheers Bertrand > > Cheers, > Luca >
